Bug:StampedLock的中断问题导致CPU爆满

StampedLock作为JAVA8中出现的新型锁,很可能在大多数场景都可以替代ReentrantReadWriteLock。它对于读/写都提供了四个接口(换成write为写锁):

  • readLock()
  • tryReadLock()
  • tryReadLock(long time, TimeUnit unit)
  • readLockInterruptibly()

这几个方法对应的语义为:

  • 获取读锁(阻塞,不响应中断)
  • 获取读锁(立即)
  • 限时获取读锁(响应中断)
  • 获取读锁(阻塞,响应中断)

然而在readLock方法(即不响应中断)中存在问题(write的版本也是),观察CPU使用率,执行以下代码:
public class TestStampedLock {
    public static void main(String[] args) throws InterruptedException{
    final StampedLock lock = new StampedLock();
    new Thread(){
       public void run(){
       long readLong = lock.writeLock();
       LockSupport.parkNanos(6100000000L);
       lock.unlockWrite(readLong);
     }
    }.start();
    Thread.sleep(100);
    for( int i = 0; i < 3; ++i)
       new Thread(new OccupiedCPUReadThread(lock)).start();
    }
    private static class OccupiedCPUReadThread implements Runnable{
        private StampedLock lock;
        public OccupiedCPUReadThread(StampedLock lock){
            this.lock = lock;
        }
        public void run(){
            Thread.currentThread().interrupt();
            long lockr = lock.readLock();
            System.out.println(Thread.currentThread().getName() + " get read lock");
            lock.unlockRead(lockr);
        }
    }
}
先开启一个线程获取写锁并保持6秒,再开启三个带着中断状态的线程去获取读锁(readLock方法),结果是3个核心被占据了近6秒。
原因在于没有使用保存/复原中断状态的机制,通过hack源码,插入保存中断和返回前恢复中断的相关代码即可修复:
boolean interrupted = false;
if(interrupted)
    Thread.currentThread().interrupt();
return ns;
if(Thread.interrupted()){
    if(interruptible)
        return cancelWaiter(node, p, true);
    else
        interrupted = true;
}

原创文章,作者:ItWorker,如若转载,请注明出处:https://blog.ytso.com/tech/pnotes/140553.html

(0)
上一篇 2021年9月5日 14:33
下一篇 2021年9月5日 15:30

相关推荐

发表回复

登录后才能评论